Skip to content

Conversation

@rodrigok
Copy link
Member

@rodrigok rodrigok commented Jul 14, 2020

Proposed changes

Implement new field nickname in order to improve user search in large organizations where name reputation is common.

Issue(s)

Closes #11189

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Nickname is a new user field that can be used to better identify users when searching for someone to add in a channel or do a mention. Useful for large organizations or countries where name repetition is common.

Further comments

@rodrigok rodrigok requested a review from ggazzo July 14, 2020 16:33
@rodrigok rodrigok added this to the 3.5.0 milestone Jul 14, 2020
@rodrigok rodrigok merged commit 10ea922 into develop Jul 15, 2020
@rodrigok rodrigok deleted the nickname branch July 15, 2020 17:25
gabriellsh added a commit that referenced this pull request Jul 15, 2020
…ite/accounts

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Message actions under "unread messages" warning (#18273)
  [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260)
  [NEW] Sign in with apple (iOS client only) (#18258)
  [IMPROVE] Message action styles (#18190)
  Rewrite Contextual Bar Discussion List in React (#18127)
  Regression: Remove calls to Console API in useForm hook (#18244)
  [FIX]Update link URL at AppsWhatIsIt (#18240)
  Update the API of React Hooks using Meteor's reactive system (#18226)
  [FIX] CAS login not merging users with local accounts (#18238)
  [FIX] SAML login crashing when receiving an array of roles (#18224)
  [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)
  Update Apps-Engine version (#18212)
  [FIX] Old Data Migrations breaking upgrades (#18185)
gabriellsh added a commit that referenced this pull request Jul 15, 2020
…into rewrite/user_preferences

* 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat:
  Regression: Message actions under "unread messages" warning (#18273)
  [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260)
  [NEW] Sign in with apple (iOS client only) (#18258)
  [IMPROVE] Message action styles (#18190)
  Rewrite Contextual Bar Discussion List in React (#18127)
  Regression: Remove calls to Console API in useForm hook (#18244)
  [FIX]Update link URL at AppsWhatIsIt (#18240)
  Update the API of React Hooks using Meteor's reactive system (#18226)
  [FIX] CAS login not merging users with local accounts (#18238)
  [FIX] SAML login crashing when receiving an array of roles (#18224)
  [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)
  Update Apps-Engine version (#18212)
  [FIX] Old Data Migrations breaking upgrades (#18185)
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add nickname to a user

3 participants